On Mon, 30 Jan 2023 17:09:23 +0000
Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> wrote:
> On Mon, 30 Jan 2023 09:21:37 -0600
> Rob Herring <robh@xxxxxxxxxx> wrote:
>
> > On Mon, Jan 30, 2023 at 07:35:26AM -0600, Rob Herring wrote:
> > >
> > > On Sun, 29 Jan 2023 15:56:02 +0000, Jonathan Cameron wrote:
> > > > From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> > > >
> > > > There has been a driver in staging for quite a while.
> > > > Given we are now moving it to the main tree, time to make sure it
> > > > has binding documentation.
> > > >
> > > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> > > >
> > > > --
> > > > V2:
> > > > - maxItems/minItems added where needed.
> > > > - fix interrupt-names to allow multiple entries.
> > > > ---
> > > > .../bindings/iio/accel/adi,adis16203.yaml | 64 +++++++++++++++++++
> > > > 1 file changed, 64 insertions(+)
> > > >
> > >
> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> > >
> > > yamllint warnings/errors:
> > >
> > > dtschema/dtc warnings/errors:
> > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/accel/adi,adis16203.example.dtb: accelerometer@0: Unevaluated properties are not allowed ('interrupt-names' was unexpected)
> > > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/accel/adi,adis16201.yaml
> >
> > I was scratching my head on this one... Check the compatible string in
> > the example. You've got 201 instead of 203.
> >
> > Are these parts that different?
> >
> > Rob
>
> Gah, Not sure why I didn't see this error - definitely something odd going on when
> I test at the moment. The parts are not particularly related.
On closer inspection they are more similar than most of the adis16xxx parts, so
it might make sense to have a combined binding and just enhance the adis16201
binding doc. I'll take a closer look at the datasheets before v3.
>
> I'll fix that and send a v3.
>
>
