On 2023-01-22 16:59:47, Jonathan Cameron wrote: > On Mon, 16 Jan 2023 23:09:04 +0100 > Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx> wrote: > > > Implement read_label in qcom-spmi-vadc to see DT-specified label names > > in userspace. At the same time clear up some documentation around > > extend_name to promote read_label, and normalize similar code in > > qcom-spmi-adc5. > > > > I think this is a good route forwards, but it is making changes > to ABI so I definitely want input on this from at least one of > the qualcomm maintainers before I pick it up - particularly > the changes in patch 3. > > Don't want to cause anyone nasty surprises. Ack, patch 3 is the odd one of the bunch (as discussed many times prior). It is an ABI break and would effectively obsolete "iio: adc: qcom-spmi-adc5: Fix the channel name" [1] as it then only affects a few dev_err/dev_dbg. Let's wait and hear from Qcom maintainers. [1]: https://lore.kernel.org/linux-arm-msm/20230118100623.42255-1-andriy.shevchenko@xxxxxxxxxxxxxxx/ - Marijn
