Re: [PATCH v4 1/3] iio: light: vcnl4000: Prepare for more generic setup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 1/17/23 16:51, Andy Shevchenko wrote:
On Tue, Jan 17, 2023 at 04:24:33PM +0100, Mårten Lindahl wrote:
In order to allow the chip_spec array reference the function pointers
for interrupts, the code for these functions need to be moved above the
chip_spec array.

This is a prestep to support a more generic setup of interrupts.
...

+	u16 buffer[8] __aligned(8) = {0}; /* 1x16-bit + naturally aligned ts */
I understand that this just a code move without a single change, but
I have to ask. Don't we use the specific struct layout for this?

Also, 0 is redundant.

P.S. Maybe considered as a followup change(s).

Hi Andy! I see your point. But yes, as it's not directly part of my change I'd prefer to handle it separately from this patch series.

Kind regards

Mårten





[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux