On Tue, Jan 17, 2023 at 04:24:34PM +0100, Mårten Lindahl wrote: > This driver supports 4 chips, by which only one (vcnl4010) handles > interrupts and has support for triggered buffer. The setup of these > functions is hardcoded for vcnl4010 inside the generic vcnl4000_probe, > and thus ignores the chip specific configuration structure where all > other chip specific functions are specified. > > This complicates adding interrupt handler and triggered buffer support > to chips which may have support for it. > > Add members for irq threads and iio_buffer_setup_ops to the generic > vcnl4000_chip_spec struct, so that instead of checking a chip specific > boolean irq support, we check for a chip specific triggered buffer > handler, and/or a chip specific irq thread handler. Thank for an update! ... > - ret = devm_request_threaded_irq(&client->dev, client->irq, > - NULL, vcnl4010_irq_thread, > + ret = devm_request_threaded_irq(&client->dev, > + client->irq, NULL, But why first line has been changed now? -- With Best Regards, Andy Shevchenko
