On Sun, 8 Jan 2023 15:45:04 -0800 Andrew Hepp <andrew.hepp@xxxxxxxxx> wrote: > From: "Andrew Hepp" <andrew.hepp@xxxxxxxxx> > > Add support for the MCP9600 thermocouple EMF converter. > > Datasheet: https://ww1.microchip.com/downloads/en/DeviceDoc/MCP960X-Data-Sheet-20005426.pdf > Signed-off-by: Andrew Hepp <andrew.hepp@xxxxxxxxx> Driver looks good, but now I realise we don't have a device tree binding doc. Please add one for v3. Note that the binding doc is describing the hardware, not what the driver currently supports alone, so include the 4 (or 6?) interrupt lines (and interrupt-names as any random subset of them might be provided) + VDD regulator + anything else I've not noticed in my 10 second look at the datashet. Thanks, Jonathan