On Fri, 23 Dec 2022 14:12:32 +0000 Jonathan Cameron <jic23@xxxxxxxxxx> wrote: > On Thu, 22 Dec 2022 15:36:08 -0500 > Hugo Villeneuve <hugo@xxxxxxxxxxx> wrote: > > > From: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx> > > > > The Analog Devices AD7924 uses an SPI interface. There is also a Texas > > Instruments ADS7924 which uses an I2C interface. > > > > Adding the SPI mention to the AD7924 will help to avoid confusion > > between the two chips. > Hi Hugo, > > Welcome to IIO. > > I don't really mind this, but given they have different part numbers > and the similarly named TI part could just have easily been SPI > I'm not sure the clarification is really useful. > > Also, under all the circumstances I can think of, if you can see the > help text you can also see the SPI dependence clearly listed. > > Hence I think is just noise, though I'm guessing it reflects a > confusion you ran into! > > Jonathan Hi Jonathan, yes, I initially tought that the TI ADS7924 was already supported because of the AD7924 entry. I wrongly assumed that the parts were similar and TI just renamed it because they bought Analog Devices. I am pretty sure that I am not the only one having made a similar error :) Of course, both chips differ not only because of their interface (SPI vs I2C), but also in their modes of operation and registers, interrupt pin presence (ADS7924), etc. But I can drop this patch if you want. Hugo V. > > Signed-off-by: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx> > > --- > > drivers/iio/adc/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig > > index 46c4fc2fc534..235319546974 100644 > > --- a/drivers/iio/adc/Kconfig > > +++ b/drivers/iio/adc/Kconfig > > @@ -243,7 +243,7 @@ config AD7923 > > select IIO_TRIGGERED_BUFFER > > help > > Say yes here to build support for Analog Devices > > - AD7904, AD7914, AD7923, AD7924 4 Channel ADCs. > > + AD7904, AD7914, AD7923, AD7924 4 Channel SPI ADCs. > > > > To compile this driver as a module, choose M here: the > > module will be called ad7923. > > -- Hugo Villeneuve <hugo@xxxxxxxxxxx>
