On Sun, Dec 11, 2022 at 04:12:51PM +0000, Biju Das wrote: > Hi William Breathitt Gray, > > Thanks for the feedback. > > > Subject: Re: [PATCH v8 3/5] Documentation: ABI: sysfs-bus-counter: add > > cascade_counts_enable and external_input_phase_clock_select > > > > On Sat, Dec 10, 2022 at 10:21:08AM +0000, Biju Das wrote: > > > +What: > > /sys/bus/counter/devices/counterX/external_input_phase_clock_select > > > +KernelVersion: 6.3 > > > +Contact: linux-iio@xxxxxxxxxxxxxxx > > > +Description: > > > + This attribute selects the external clock pin for phase > > > + counting mode of counter X. > > > > Hi Biju, > > > > Remove the "This attribute" from the description, and capitalize the word > > "counter": "Selects the external clock pin for phase counting mode of > > Counter X." > > > > > +What: > > /sys/bus/counter/devices/counterX/external_input_phase_clock_select_ > > available > > > > At some point in the future I should combine the *_available blocks, but > > right now they're separated between Count and Signal configurations. > > This external_input_phase_clock_select_available is a device-level > > configuration so it'll need its own block as well, such as the following. > > Since it is device-level configuration, I will move the below 3 blocks > to the top of file. I hope it is ok to you. That's okay with me, so go ahead. I think at one point I was trying to keep the attributes listed in alphabetical order, but I haven't really minded lately as long as the information in this file is clear. William Breathitt Gray > > +What: /sys/bus/counter/devices/counterX/cascade_counts_enable > +KernelVersion: 6.3 > +Contact: linux-iio@xxxxxxxxxxxxxxx > +Description: > + Indicates the cascading of Counts on Counter X. > + > + Valid attribute values are boolean. > + > +What: /sys/bus/counter/devices/counterX/external_input_phase_clock_select > +KernelVersion: 6.3 > +Contact: linux-iio@xxxxxxxxxxxxxxx > +Description: > + Selects the external clock pin for phase counting mode of > + Counter X. > + > + MTCLKA-MTCLKB: > + MTCLKA and MTCLKB pins are selected for the external > + phase clock. > + > + MTCLKC-MTCLKD: > + MTCLKC and MTCLKD pins are selected for the external > + phase clock. > + > +What: /sys/bus/counter/devices/counterX/external_input_phase_clock_select_available > +KernelVersion: 6.3 > +Contact: linux-iio@xxxxxxxxxxxxxxx > +Description: > + Discrete set of available values for the respective device > + configuration are listed in this file. > > Cheers, > Biju
Attachment:
signature.asc
Description: PGP signature
