From: ye xingchen <ye.xingchen@xxxxxxxxxx> Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. Signed-off-by: ye xingchen <ye.xingchen@xxxxxxxxxx> --- drivers/iio/magnetometer/hmc5843_core.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/iio/magnetometer/hmc5843_core.c b/drivers/iio/magnetometer/hmc5843_core.c index c5521d61da29..134f6045e24a 100644 --- a/drivers/iio/magnetometer/hmc5843_core.c +++ b/drivers/iio/magnetometer/hmc5843_core.c @@ -274,9 +274,9 @@ ssize_t hmc5843_show_samp_freq_avail(struct device *dev, int i; for (i = 0; i < data->variant->n_regval_to_samp_freq; i++) - len += scnprintf(buf + len, PAGE_SIZE - len, - "%d.%d ", data->variant->regval_to_samp_freq[i][0], - data->variant->regval_to_samp_freq[i][1]); + len += sysfs_emit_at(buf, len, "%d.%d ", + data->variant->regval_to_samp_freq[i][0], + data->variant->regval_to_samp_freq[i][1]); /* replace trailing space by newline */ buf[len - 1] = '\n'; @@ -335,8 +335,7 @@ static ssize_t hmc5843_show_scale_avail(struct device *dev, int i; for (i = 0; i < data->variant->n_regval_to_nanoscale; i++) - len += scnprintf(buf + len, PAGE_SIZE - len, - "0.%09d ", data->variant->regval_to_nanoscale[i]); + len += sysfs_emit_at(buf, len, "0.%09d ", data->variant->regval_to_nanoscale[i]); /* replace trailing space by newline */ buf[len - 1] = '\n'; -- 2.25.1
