From: ye xingchen <ye.xingchen@xxxxxxxxxx> Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. Signed-off-by: ye xingchen <ye.xingchen@xxxxxxxxxx> --- drivers/iio/light/bh1750.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/iio/light/bh1750.c b/drivers/iio/light/bh1750.c index 390c5b3ad4f6..ab682865885d 100644 --- a/drivers/iio/light/bh1750.c +++ b/drivers/iio/light/bh1750.c @@ -194,8 +194,7 @@ static ssize_t bh1750_show_int_time_available(struct device *dev, const struct bh1750_chip_info *chip_info = data->chip_info; for (i = chip_info->mtreg_min; i <= chip_info->mtreg_max; i += chip_info->inc) - len += scnprintf(buf + len, PAGE_SIZE - len, "0.%06d ", - chip_info->mtreg_to_usec * i); + len += sysfs_emit_at(buf, len, "0.%06d ", chip_info->mtreg_to_usec * i); buf[len - 1] = '\n'; -- 2.25.1
