From: ye xingchen <ye.xingchen@xxxxxxxxxx> Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. Signed-off-by: ye xingchen <ye.xingchen@xxxxxxxxxx> --- drivers/iio/humidity/hts221_core.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/iio/humidity/hts221_core.c b/drivers/iio/humidity/hts221_core.c index 2a413da87b76..e4ae4ffb9ffb 100644 --- a/drivers/iio/humidity/hts221_core.c +++ b/drivers/iio/humidity/hts221_core.c @@ -200,8 +200,7 @@ static ssize_t hts221_sysfs_sampling_freq(struct device *dev, ssize_t len = 0; for (i = 0; i < ARRAY_SIZE(hts221_odr_table); i++) - len += scnprintf(buf + len, PAGE_SIZE - len, "%d ", - hts221_odr_table[i].hz); + len += sysfs_emit_at(buf, len, "%d ", hts221_odr_table[i].hz); buf[len - 1] = '\n'; return len; @@ -217,8 +216,7 @@ hts221_sysfs_rh_oversampling_avail(struct device *dev, int i; for (i = 0; i < ARRAY_SIZE(avg->avg_avl); i++) - len += scnprintf(buf + len, PAGE_SIZE - len, "%d ", - avg->avg_avl[i]); + len += sysfs_emit_at(buf, len, "%d ", avg->avg_avl[i]); buf[len - 1] = '\n'; return len; @@ -234,8 +232,7 @@ hts221_sysfs_temp_oversampling_avail(struct device *dev, int i; for (i = 0; i < ARRAY_SIZE(avg->avg_avl); i++) - len += scnprintf(buf + len, PAGE_SIZE - len, "%d ", - avg->avg_avl[i]); + len += sysfs_emit_at(buf, len, "%d ", avg->avg_avl[i]); buf[len - 1] = '\n'; return len; -- 2.25.1