On Tue, Dec 06, 2022 at 07:53:20PM +0800, ye.xingchen@xxxxxxxxxx wrote: > From: ye xingchen <ye.xingchen@xxxxxxxxxx> > > Follow the advice of the Documentation/filesystems/sysfs.rst and show() > should only use sysfs_emit() or sysfs_emit_at() when formatting the > value to be returned to user space. Please split on per device driver basis (3 patches here). The code looks fine to me, thanks. -- With Best Regards, Andy Shevchenko