On Wed, 23 Nov 2022 19:49:18 +0000 Jonathan Cameron <jic23@xxxxxxxxxx> wrote: > On Wed, 23 Nov 2022 19:40:56 +0100 > Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > > On Wed, Nov 16, 2022 at 07:03:08PM +0000, Jonathan Cameron wrote: > > > The following changes since commit 30a0b95b1335e12efef89dd78518ed3e4a71a763: > > > > > > Linux 6.1-rc3 (2022-10-30 15:19:28 -0700) > > > > > > are available in the Git repository at: > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git tags/iio-for-6.2a > > > > I get the following error when trying to push these out: > > > > Commit: 3acdb4a11517 ("iio: adc: ad_sigma_delta: do not use internal iio_dev lock") > > Fixes tag: Fixes: af3008485ea0 ("iio:adc: Add common code for ADI Sigma Deltadevices") > > Has these problem(s): > > - Subject does not match target commit subject > > Just use > > git log -1 --format='Fixes: %h ("%s")' > > > > > > linux-next should have also warned of this, right? > > It didn't... Or the email got eaten by something (maybe me) > Sorry about that. > > Jonathan > > > > Can you fix this up and resend? > > Coming right up - assuming I don't mess up rebasing. Gah. I hate fixes tags sometimes (on the plus side I do like your script for checking them which I'd obviously failed to run on the very first patch on my tree for some reason). 6 others were broken as a result of the rebase to fix this one and needed manual repair. Anyhow, fingers crossed v2 is in better shape. Thankfully everything I have queued for a second pull request so far hasn't had fixes tags. I plan to let the second set have a few days in Linux next before sending another (hopefully better!) final pull request for 6.2 stuff. Thanks as ever for your help and one day I'll get this right first time every time :( Jonathan > > > > > thanks, > > > > greg k-h >
