On Fri, 11 Nov 2022 10:25:39 -0500 Paul Gazzillo <paul@xxxxxxxxx> wrote: > On 11/11/2022, Andy Shevchenko wrote: > > On Thu, Nov 10, 2022 at 04:47:29PM -0500, Paul Gazzillo wrote: > > > Fix an implicit declaration of function error for rpr0521 under some configs > > > > > > When CONFIG_RPR0521 is enabled without CONFIG_IIO_TRIGGERED_BUFFER, > > > the build results in "implicit declaration of function" errors, e.g., > > > drivers/iio/light/rpr0521.c:434:3: error: implicit declaration of function > > > 'iio_trigger_poll_chained' [-Werror=implicit-function-declaration] > > > 434 | iio_trigger_poll_chained(data->drdy_trigger0); > > > | ^~~~~~~~~~~~~~~~~~~~~~~~ > > > > > > This fix adds select dependencies to RPR0521's configuration declaration. > > > > > > Signed-off-by: Paul Gazzillo <paul@xxxxxxxxx> > > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=216678 > > > > No need to create a bugzilla report on such tiny issues that do actually not > > affect the working configurations. > > Understood. Thanks for your help! I wonder why it has taken so long for this build issue to get reported? Ah well. This is missing a fixes tag. I added Fixes: e12ffd241c00 ("iio: light: rpr0521 triggered buffer") Applied to the fixes-togreg branch of iio.git. Thanks, Jonathan > > > > > FWIW, > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > > > > > --- > > > V1 -> V2: Cleaned up commit message per reviewer comments and added link > > > to bug report. > > > > > > drivers/iio/light/Kconfig | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/drivers/iio/light/Kconfig b/drivers/iio/light/Kconfig > > > index 7cf6e8490123..0d4447df7200 100644 > > > --- a/drivers/iio/light/Kconfig > > > +++ b/drivers/iio/light/Kconfig > > > @@ -293,6 +293,8 @@ config RPR0521 > > > tristate "ROHM RPR0521 ALS and proximity sensor driver" > > > depends on I2C > > > select REGMAP_I2C > > > + select IIO_BUFFER > > > + select IIO_TRIGGERED_BUFFER > > > help > > > Say Y here if you want to build support for ROHM's RPR0521 > > > ambient light and proximity sensor device. > > > -- > > > 2.25.1 > > > > -- > > With Best Regards, > > Andy Shevchenko > > Best, > Paul
