Hi Jonathan, On Sun, Oct 23, 2022 at 12:12:22PM +0100, Jonathan Cameron wrote: > On Fri, 21 Oct 2022 17:32:21 +0200 > Marcus Folkesson <marcus.folkesson@xxxxxxxxx> wrote: > > > Hi Mitja, > > > > On Fri, Oct 21, 2022 at 03:58:21PM +0200, Mitja Spes wrote: > > > Don't hardcode the ms5611 SPI speed, limit it instead. > > > > > > Signed-off-by: Mitja Spes <mitja@xxxxxxxxx> > > > --- > > > drivers/iio/pressure/ms5611_spi.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/iio/pressure/ms5611_spi.c b/drivers/iio/pressure/ms5611_spi.c > > > index 432e912096f4..a0a7205c9c3a 100644 > > > --- a/drivers/iio/pressure/ms5611_spi.c > > > +++ b/drivers/iio/pressure/ms5611_spi.c > > > @@ -91,7 +91,7 @@ static int ms5611_spi_probe(struct spi_device *spi) > > > spi_set_drvdata(spi, indio_dev); > > > > > > spi->mode = SPI_MODE_0; > > > - spi->max_speed_hz = 20000000; > > > + spi->max_speed_hz = min(spi->max_speed_hz, 20000000U); > > > > max_speed_hz is a limit, and the max frequency the ms5611 support is > > 20MHz. > Hi Marcus, > > I'm not following what you are commenting on.. Perhaps give more > detail? Sorry for being unclear. However, I must have thought wrong, this is good as it takes the speedlimit set in e.g. devicetree into account. > > Thanks, > > Jonathan > > > > > Best regards, > > Marcus Folkesson > Best regards, Marcus Folkesson
Attachment:
signature.asc
Description: PGP signature
