On Tue, 27 Sep 2022 14:44:35 +0800
Yang Yingliang <yangyingliang@xxxxxxxxxx> wrote:
> In the probe path, dev_err() can be replaced with dev_err_probe()
> which will check if error code is -EPROBE_DEFER and prints the
> error name. It also sets the defer probe reason which can be
> checked later through debugfs. It's more simple in error path.
>
> Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>
Similar patch already queued for 6.2 from Yuan Can
Thanks,
Jonathan
> ---
> drivers/iio/accel/bma400_core.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/iio/accel/bma400_core.c b/drivers/iio/accel/bma400_core.c
> index ad8fce3e08cd..e4de649b6701 100644
> --- a/drivers/iio/accel/bma400_core.c
> +++ b/drivers/iio/accel/bma400_core.c
> @@ -886,14 +886,10 @@ static int bma400_init(struct bma400_data *data)
> ret = devm_regulator_bulk_get(data->dev,
> ARRAY_SIZE(data->regulators),
> data->regulators);
> - if (ret) {
> - if (ret != -EPROBE_DEFER)
> - dev_err(data->dev,
> - "Failed to get regulators: %d\n",
> - ret);
> + if (ret)
> + return dev_err_probe(data->dev, ret,
> + "Failed to get regulators\n");
>
> - return ret;
> - }
> ret = regulator_bulk_enable(ARRAY_SIZE(data->regulators),
> data->regulators);
> if (ret) {
