On Tue, 27 Sep 2022 19:20:00 +0300 Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > On Tue, Sep 27, 2022 at 08:46:11AM -0700, Dmitry Torokhov wrote: > > The driver is using of_device_id/of_match_ptr() and therefore needs > > to include of.h header. We used to get this definition indirectly via > > inclusion of matrix_keypad.h from twl.h, but we are cleaning up > > matrix_keypad.h from unnecessary includes. > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Applied to the togreg branch of iio.git and pushed out as testing for 0-day to take a look. Note that this is 6.2 material now - if that's an issue for the matrix_keypad.h cleanup then feel free to take it via the input tree with Acked-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> but shout in reply to this so I know to drop it from the iio tree. Thanks, Jonathan > > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> > > --- > > > > v2: adjusted patch description > > > > drivers/iio/adc/twl4030-madc.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/iio/adc/twl4030-madc.c b/drivers/iio/adc/twl4030-madc.c > > index f8f8aea15612..c279c4f2c9b7 100644 > > --- a/drivers/iio/adc/twl4030-madc.c > > +++ b/drivers/iio/adc/twl4030-madc.c > > @@ -30,6 +30,7 @@ > > #include <linux/types.h> > > #include <linux/gfp.h> > > #include <linux/err.h> > > +#include <linux/of.h> > > #include <linux/regulator/consumer.h> > > > > #include <linux/iio/iio.h> > > -- > > 2.38.0.rc1.362.ged0d419d3c-goog > > >