On Wed, 21 Sep 2022 02:39:15 +0000
Yuan Can <yuancan@xxxxxxxxxx> wrote:
> In the probe path, dev_err() can be replace with dev_err_probe()
> which will check if error code is -EPROBE_DEFER and prints the
> error name.
>
> Signed-off-by: Yuan Can <yuancan@xxxxxxxxxx>
@Dan. whilst reviewing this one I noticed we are turning the power to vddio (which
I assume is the supply for the IO interface) after reading the chip ID. That
doesn't seem right!
Unrelated to this patch beyond I was looking to see if there were other cases
for dev_err_probe() in here.
Applied but it may well not make the next merge window as I'm not sure I'll get
another IIO pull request out before that opens. Currently Linus has hinted
at a possible rc8 but we will know more on that after he tags rc7 tomorrow.
Jonathan
> ---
> drivers/iio/accel/bma400_core.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/iio/accel/bma400_core.c b/drivers/iio/accel/bma400_core.c
> index eceb1f8d338d..cebd7e370b09 100644
> --- a/drivers/iio/accel/bma400_core.c
> +++ b/drivers/iio/accel/bma400_core.c
> @@ -886,14 +886,10 @@ static int bma400_init(struct bma400_data *data)
> ret = devm_regulator_bulk_get(data->dev,
> ARRAY_SIZE(data->regulators),
> data->regulators);
> - if (ret) {
> - if (ret != -EPROBE_DEFER)
> - dev_err(data->dev,
> - "Failed to get regulators: %d\n",
> - ret);
> + if (ret)
> + return dev_err_probe(data->dev, ret, "Failed to get regulators: %d\n",
> + ret);
>
> - return ret;
> - }
> ret = regulator_bulk_enable(ARRAY_SIZE(data->regulators),
> data->regulators);
> if (ret) {
