Hi Andy, I love your patch! Perhaps something to improve: [auto build test WARNING on broonie-spi/for-next] [also build test WARNING on linus/master v6.0-rc6 next-20220921] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/spi-Introduce-spi_get_device_match_data-helper/20220922-044658 base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next config: s390-randconfig-s031-20220921 (https://download.01.org/0day-ci/archive/20220922/202209221302.UKxElkNH-lkp@xxxxxxxxx/config) compiler: s390-linux-gcc (GCC) 12.1.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # apt-get install sparse # sparse version: v0.6.4-39-gce1a6720-dirty # https://github.com/intel-lab-lkp/linux/commit/4d7a10e29738f98137b08b2dcc0297535dd92a11 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Andy-Shevchenko/spi-Introduce-spi_get_device_match_data-helper/20220922-044658 git checkout 4d7a10e29738f98137b08b2dcc0297535dd92a11 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=s390 SHELL=/bin/bash drivers/spi/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> sparse warnings: (new ones prefixed by >>) >> drivers/spi/spi.c:367:40: sparse: sparse: incorrect type in argument 1 (different modifiers) @@ expected struct device *dev @@ got struct device const * @@ drivers/spi/spi.c:367:40: sparse: expected struct device *dev drivers/spi/spi.c:367:40: sparse: got struct device const * vim +367 drivers/spi/spi.c 362 363 const void *spi_get_device_match_data(const struct spi_device *sdev) 364 { 365 const void *match; 366 > 367 match = device_get_match_data(&sdev->dev); 368 if (match) 369 return match; 370 371 return (const void *)spi_get_device_id(sdev)->driver_data; 372 } 373 EXPORT_SYMBOL_GPL(spi_get_device_match_data); 374 -- 0-DAY CI Kernel Test Service https://01.org/lkp
