Re: [PATCH] iio: adc: ad7124: Silent no spi_device_id warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 2022/9/19 23:53, Jonathan Cameron wrote:
> On Mon, 19 Sep 2022 22:50:35 +0800
> Wei Yongjun <weiyongjun1@xxxxxxxxxx> wrote:
> 
>> On 2022/9/19 22:46, Lars-Peter Clausen wrote:
>>> On 9/19/22 16:59, Wei Yongjun wrote:  
>>>> From: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
> Hi Wei Yongjun,
> 
>>>>
>>>> Add spi_device_id entries to silent following SPI warnings:
> 
> silence rather than silent (also in patch titles)
> 
>>>>
>>>> SPI driver ad7124 has no spi_device_id for adi,ad7124-4
>>>> SPI driver ad7124 has no spi_device_id for adi,ad7124-8  
>>> What generates those warnings?
>>>   
>>
>> Commit 5fa6863ba692 ("spi: Check we have a spi_device_id for each DT
>> compatible") added a test to check that every SPI driver has a
>> spi_device_id for each DT compatiable string defined by the driver
>> and warns if the spi_device_id is missing.
> 
> When sending a series of similar fixes to a given subsystem together
> it's helpful to group them into a series, so that comments that
> apply series wide can easily be easily found.
> 
> A cover letter is also useful to provide a little more information on
> what is being fixed.


Sure, will update in v3.

Thanks.




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux