On Mon, 19 Sep 2022 09:10:52 +0300 Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > On Sun, Sep 18, 2022 at 06:45:03PM +0100, Jonathan Cameron wrote: > > On Sun, 18 Sep 2022 20:05:48 +0530 > > Jagath Jog J <jagathjog1996@xxxxxxxxx> wrote: > > > > > Hi Jonathan, > > > > > > Thank you for sending this patch. > > > If you need a tag for this fix. > > > > > > Fixes: 961db2da159d ("iio: accel: bma400: Add support for single and > > > double tap events") > > Good point. I'm careful about fixes tags to stuff still not upstream > > because they tend to be a little unstable. This should be fine. > > I'll see if it's valid when I rebase the tree (hopefully in a few days > > time). > > If you forget to update the tags after a rebase then Stephen Rothwell > will let you know. It's best to not make Stephen's job more difficult, > but it's some comfort to know that mistakes will get caught. > > regards, > dan carpenter > Hi Dan, Having messed this up and caused Stephen pointless work several times I now have scripting (thanks to Greg KH's scripts and some local modes to make sure the tag is in the upstream of the fix) to check this but some how I still mess it up from time to time :( Jonathan