On Sat, 2022-09-17 at 14:25 +0100, Jonathan Cameron wrote: > On Tue, 13 Sep 2022 01:52:13 +0200 > Angel Iglesias <ang.iglesiasg@xxxxxxxxx> wrote: > > > Adds compatibility with the new generation of this sensor, the BMP380. > > > > Includes basic sensor initialization to do pressure and temp > > measurements and allows tuning oversampling settings for each channel. > > > > The compensation algorithms are adapted from the device datasheet and > > the repository https://github.com/BoschSensortec/BMP3-Sensor-API. > > > > Signed-off-by: Angel Iglesias <ang.iglesiasg@xxxxxxxxx> > There is one place (around the reset handing) in here where I > suspect we'll end up revisiting it because the matching by > device ID is not particularly extensible to new devices. Yeah, after the first time you raised that concern I've been thinking that maybe it would be better to add a new "init" or "preinit" callback executing first boot tasks for a sensor, such as this reset. Please, let me know how I can help with this matter. On the other hand, I'll have the BMP390 and BMP581 on my hands in a week or two. The BMP390 is almost the same regmap and operations as the BMP380, so I think it will be an easy addition. The BMP581 is a new beast that brings in lots of changes, but still has a good bunch of similarities. > Anyhow, can handle that at the time. > > I had to hand apply parts of this because of the clash Andy > raised. As a general rule it's better to keep one linear > flow of patches unless they are on well separate parts of > a driver. Saves me effort :) Here it was just one line to > cut and paste, but you still get to now check I didn't mess > that up ;) Sorry about that. Thanks to you and Andy for the extra patience with my messy patches. > Applied - please check result in testing branch of iio.git. > > Note I plan to rebase that branch after the first pull request > is accepted as I have some dependencies blocking other > patches and a fast forward rebase is the easiest way to deal > with those cleanly. > > Jonathan With kind regards, Angel
