Hi Jonathan, I added another filter attribute for sinc4 filter. Enabling sinc4 disables fir filters. Disabling sinc4 defaults back to both fir filters being enabled. Sinc4 filter center matches the configured sampling frequency. GPIO configuration now depends on the interrupt-names property. Leaving it blank results in probe error when there is an interrupt specified. Regards, Ibrahim Note: No sign-off tag for David as he was unreachable when the initial patch was sent. Changelog: since v4: - add in_voltage_filter2_notch_{center,en} attrs for sinc4 filter - add ABI documentation for filter sysfs - check interrupt-names property for configuring gpio of max11410 - remove hardwaregain property - add scale_available property for channes using PGA - separate vref regulator error -ENODEV from other errors - don't register trigger if no irq specified - style fixes since v3: - prefix defines with MAX11410_ - group vref regulators - use builtin iio_validate_scan_mask_onehot - validate iio trigger - move scan data into state struct - require vrefn regulator in DT if used by any channel - don't require irq for triggered buffer - remove filter sysfs attr and ABI documentation - add in_voltage_filter[0-1]_notch_{center,en} attrs since v2: - remove bit position shifting, use field_prep instead - reduce the amount of reg writes in max11410_configure_channel - add error checking in max11410_parse_channels - remove some unneeded blank lines and minor style fixes - remove scan data assignment in max11410_trigger_handler Ibrahim Tilki (3): iio: adc: add max11410 adc driver dt-bindings: iio: adc: add adi,max11410.yaml Documentation: ABI: testing: add max11410 doc .../ABI/testing/sysfs-bus-iio-adc-max11410 | 13 + .../bindings/iio/adc/adi,max11410.yaml | 174 +++ drivers/iio/adc/Kconfig | 13 + drivers/iio/adc/Makefile | 1 + drivers/iio/adc/max11410.c | 1051 +++++++++++++++++ 5 files changed, 1252 insertions(+) create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-adc-max11410 create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,max11410.yaml create mode 100644 drivers/iio/adc/max11410.c -- 2.36.1