On Tue, 6 Sept 2022 at 12:21, Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > > Very good and documented code, thanks! > I believe you better to use DEFINE_.*_PM_OPS instead of legacy ones > (due to pm_ptr() usage). > Otherwise, with some nitpicks that wouldn't prevent a green light, > Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > I checked DEFINE_.*_PM_OPS usage around drivers and you either have SIMPLE (where you define suspend/resume) or you have RUNTIME (for runtime suspend/resume), but never are those two together. So I am a bit puzzled how to get this working.
