On Sun, Sep 4, 2022 at 5:37 PM Jonathan Cameron <jic23@xxxxxxxxxx> wrote: > On Sat, 3 Sep 2022 14:05:38 +0200 > Crt Mori <cmo@xxxxxxxxxxx> wrote: > > On Fri, 2 Sept 2022 at 20:39, Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > > > On Fri, Sep 2, 2022 at 8:59 PM Crt Mori <cmo@xxxxxxxxxxx> wrote: > > > > On Fri, 2 Sept 2022 at 17:28, Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > > > > > On Fri, Sep 2, 2022 at 4:13 PM <cmo@xxxxxxxxxxx> wrote: ... > > > > > > +static int __maybe_unused mlx90632_pm_runtime_suspend(struct device *dev) > > > > > > > > > > No __maybe_unused, use pm_ptr() / pm_sleep_ptr() below. > > > > > > > > > Care to explain a bit more about this? I just followed what other > > > > drivers have... > > > > > > And other drivers have what I said, but it's a new feature. > > > If you run `git log --no-merges --grep 'pm_ptr' -- drivers/iio > > > include/linux/` and read the history it will explain the case. > > > > > Thanks for the hint. > > The relevant EXPORT_ for this particular case isn't upstream yet > We had a proposal on IIO list, but there was a better one as part of > cleaning this up for MFD. I haven't checked if there is a suitable > immutable branch for that patch yet... Oh, well to know. But in any case pm_ptr() / DEFINE_*PM_OPS can still be used. -- With Best Regards, Andy Shevchenko
