On Wed, Aug 31, 2022 at 1:01 PM Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx> wrote:
All below are minors (but you really need to Cc reviewers from the
previous round(s) to pay the respect), so I leave them to IIO
maintainers.
...
> Add spi_device_id to silent following kernel runtime warning:
> "SPI driver tsc2046 has no spi_device_id for ti,tsc2046e-adc"
Missed period.
> dcfg = device_get_match_data(dev);
> + if (!dcfg) {
> + const struct spi_device_id *id;
> +
> + id = spi_get_device_id(spi);
You can move assignment to the definition line.
> + dcfg = (const struct tsc2046_adc_dcfg *)id->driver_data;
> + }
> +
Unneeded blank line, since these all are grouped semantically.
> if (!dcfg)
> return -EINVAL;
--
With Best Regards,
Andy Shevchenko
