On 24/08/2022 15:52, Ramona Bolboaca wrote: > Add bindings documentation file and MAINTAINERS entry for MAX11205. > > Signed-off-by: Ramona Bolboaca <ramona.bolboaca@xxxxxxxxxx> > --- > .../bindings/iio/adc/maxim,max11205.yaml | 65 +++++++++++++++++++ > MAINTAINERS | 8 +++ > 2 files changed, 73 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/maxim,max11205.yaml > > diff --git a/Documentation/devicetree/bindings/iio/adc/maxim,max11205.yaml b/Documentation/devicetree/bindings/iio/adc/maxim,max11205.yaml > new file mode 100644 > index 000000000000..bddd18a44969 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/adc/maxim,max11205.yaml > @@ -0,0 +1,65 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/adc/maxim,max11205.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Maxim MAX11205 ADC > + > +maintainers: > + - Ramona Bolboaca <ramona.bolboaca@xxxxxxxxxx> > + > +description: | > + The MAX11205 is an ultra-low-power (< 300FA max > + active current), high-resolution, serial-output ADC. > + > + https://datasheets.maximintegrated.com/en/ds/MAX11205.pdf > + > +properties: > + compatible: > + enum: > + - maxim,max11205a > + - maxim,max11205b > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + spi-max-frequency: > + maximum: 5000000 > + > + spi-cpha: true Both properties are good, but still you should reference /schemas/spi/spi-peripheral-props.yaml in allOf and use unevaluatedProperties:false. See other bindings for SPI devices. > + > + vref-supply: > + description: > + The regulator supply for the ADC reference voltage. > + > +required: > + - compatible > + - reg > + - spi-max-frequency > + - spi-cpha > + - interrupts > + - vref-supply > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/irq.h> > + spi { > + #address-cells = <1>; > + #size-cells = <0>; > + max11205@0 { adc Node names should be generic. https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + compatible = "maxim,max11205a"; Messed up indentation. Use 4 spaces. > + reg = <0>; > + spi-max-frequency = <5000000>; > + spi-cpha; Best regards, Krzysztof
