On Fri, 19 Aug 2022 12:57:54 +0000 Dmitry Rokosov <DDRokosov@xxxxxxxxxxxxxx> wrote: > On Fri, Aug 19, 2022 at 11:41:55AM +0300, Andy Shevchenko wrote: > > [...] > > > > Spec: https://cdn-shop.adafruit.com/product-files/5309/MSA311-V1.1-ENG.pdf > > > > Have you ever seen such a tag? > > We have the Datasheet that is more or less established for this kind of links. > > As I mentioned before, if I use Datasheet tag, line length limit will be > exceeded. If it's okay, I don't mind. Fine to go long. If someone can't see the remaining chars of a link on their 80 character wide terminal - they can scroll sideways :) > > > > > +static inline int msa311_set_odr(struct msa311_priv *msa311, unsigned int odr) > > > > Why inline? > > > > Why not? :) It's short function which is good to be inline, I think. Let the compiler decide that. Generally in kernel code, inline is reserved for the few places it's necessary or where compilers have been shown to get it wrong. > > > > +{ > > > + struct device *dev = msa311->dev; > > > + unsigned int pwr_mode; > > > > > + bool good_odr = false; > >
