Re: [PATCH 1/4] iio/adc: ingenic: fix channel offsets in buffer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andy,

Le ven., août 19 2022 at 11:12:38 +0300, Andy Shevchenko <andy.shevchenko@xxxxxxxxx> a écrit :
On Wed, Aug 17, 2022 at 1:58 PM Artur Rojek <contact@xxxxxxxxxxxxxx> wrote:

 Consumers expect the buffer to only contain enabled channels. While
preparing the buffer, the driver also (incorrectly) inserts empty data for disabled channels, causing the enabled channels to appear at wrong
 offsets. Fix that.

What consumers? Have you tested on all of them? Please, elaborate. It
might be that some of them have to be fixed. In such case you need to
report the issue to their respective channels and put the
corresponding links here.

There are no consumers to fix, only this driver. I believe it wasn't noticed until now because all consumers were only using channels 0 and 1.

Cheers,
-Paul

P.S. It doesn't mean I'm against the patch.

--
With Best Regards,
Andy Shevchenko






[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux