On Thu, 11 Aug 2022 13:42:41 +0000
Ibrahim Tilki <Ibrahim.Tilki@xxxxxxxxxx> wrote:
> I added filter enable attributes for 50Hz and 60Hz FIR filters.
> Disabling both will set filter to sinc4, allowing higher sampling rates.
>
> Regards,
> Ibrahim
>
> Note: No sign-off tag for David as he was unreachable when the initial patch was sent.
>
> Changelog:
> since v3:
> - prefix defines with MAX11410_
> - group vref regulators
> - use builtin iio_validate_scan_mask_onehot
> - validate iio trigger
> - move scan data into state struct
> - require vrefn regulator in DT if used by any channel
> - don't require irq for triggered buffer
> - remove filter sysfs attr and ABI documentation
> - add in_voltage_filter[0-1]_notch_{center,en} attrs
I'm not seeing a documentation patch for this new ABI.
It's subtly different from the existing entries in
Documentation/ABI/testing/sysfs-bus-iio and the _en part is
new in general for filters.
I'll take a look at the rest of the code, but Docs need to
be in place and reviewed before I can take the driver.
Thanks,
Jonathan
>
> since v2:
> - remove bit position shifting, use field_prep instead
> - reduce the amount of reg writes in max11410_configure_channel
> - add error checking in max11410_parse_channels
> - remove some unneeded blank lines and minor style fixes
> - remove scan data assignment in max11410_trigger_handler
>
>
> Ibrahim Tilki (2):
> iio: adc: add max11410 adc driver
> dt-bindings: iio: adc: add adi,max11410.yaml
>
> .../bindings/iio/adc/adi,max11410.yaml | 165 +++
> drivers/iio/adc/Kconfig | 13 +
> drivers/iio/adc/Makefile | 1 +
> drivers/iio/adc/max11410.c | 954 ++++++++++++++++++
> 4 files changed, 1133 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,max11410.yaml
> create mode 100644 drivers/iio/adc/max11410.c
>
