On Sun, 7 Aug 2022 13:55:52 +0200 Angel Iglesias <ang.iglesiasg@xxxxxxxxx> wrote: > Adds compatibility with the new generation of this sensor, the BMP380 > > Includes basic sensor initialization to do pressure and temp > measurements and allows tuning oversampling settings for each channel. > > The compensation algorithms are adapted from the device datasheet and > the repository https://github.com/BoschSensortec/BMP3-Sensor-API > > Signed-off-by: Angel Iglesias <ang.iglesiasg@xxxxxxxxx> One additional comment from me inline. Thanks, Jonathan > } > @@ -1124,6 +1471,13 @@ int bmp280_common_probe(struct device *dev, > return -EINVAL; > } > > + /* BMP3xx requires soft-reset as part of initialization */ > + if (chip_id == BMP380_CHIP_ID) { I'd prefer this to be based on a flag in chip_info so that we can trivially add it to future devices by just setting that flag for the chip_info added for the new device. > + ret = bmp380_cmd(data, BMP380_CMD_SOFT_RESET); > + if (ret < 0) > + return ret; > + } > + > ret = data->chip_info->chip_config(data); > if (ret < 0) > return ret;
