Re: [PATCH v5 09/14] iio: magnetometer: yas530: Introduce "chip_info" structure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 8, 2022 at 1:07 AM Jakob Hauser <jahau@xxxxxxxxxxxxxx> wrote:

...

> +       yas5xx->chip = id->driver_data;
> +       yas5xx->chip_info = &yas5xx_chip_info_tbl[yas5xx->chip];

I don't see how ->chip is being used, I would expect it is the part of
chip_info, if it's really needed. That said, please make it directly a
pointer, so the above becomes:

  ... ->chip_info = (const struct ...)id->driver_data;

...

> +       {"yas530", yas530 },
> +       {"yas532", yas532 },
> +       {"yas533", yas533 },

Read above and here:

  yas53... ==> (kernel_ulong_t)&...[yas53...]

-- 
With Best Regards,
Andy Shevchenko



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux