On Mon, Aug 8, 2022 at 1:07 AM Jakob Hauser <jahau@xxxxxxxxxxxxxx> wrote:
>
> Use less stack by modifying %*ph parameters.
>
> Additionally, in the function yas530_get_calibration_data(), the debug dump was
Additionally --> While at it
(The difference is that "additionally" means you need to split to two
changes, which makes a little sense in this case)
> extended to 16 elements as this is the size of the calibration data array of
> YAS530.
Otherwise looks good,
Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
> Signed-off-by: Jakob Hauser <jahau@xxxxxxxxxxxxxx>
> Suggested-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
> ---
> drivers/iio/magnetometer/yamaha-yas530.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/magnetometer/yamaha-yas530.c b/drivers/iio/magnetometer/yamaha-yas530.c
> index b27cc2b432ee..48995176fa39 100644
> --- a/drivers/iio/magnetometer/yamaha-yas530.c
> +++ b/drivers/iio/magnetometer/yamaha-yas530.c
> @@ -664,7 +664,7 @@ static int yas530_get_calibration_data(struct yas5xx *yas5xx)
> ret = regmap_bulk_read(yas5xx->map, YAS530_CAL, data, sizeof(data));
> if (ret)
> return ret;
> - dev_dbg(yas5xx->dev, "calibration data: %*ph\n", 14, data);
> + dev_dbg(yas5xx->dev, "calibration data: %16ph\n", data);
>
> add_device_randomness(data, sizeof(data));
> yas5xx->version = data[15] & GENMASK(1, 0);
> @@ -711,7 +711,7 @@ static int yas532_get_calibration_data(struct yas5xx *yas5xx)
> ret = regmap_bulk_read(yas5xx->map, YAS530_CAL, data, sizeof(data));
> if (ret)
> return ret;
> - dev_dbg(yas5xx->dev, "calibration data: %*ph\n", 14, data);
> + dev_dbg(yas5xx->dev, "calibration data: %14ph\n", data);
>
> /* Sanity check, is this all zeroes? */
> if (memchr_inv(data, 0x00, 13) == NULL) {
--
With Best Regards,
Andy Shevchenko
