On Wed, Jul 27, 2022 at 06:46:40PM +0200, Krzysztof Kozlowski wrote: > diff --git a/Documentation/devicetree/bindings/iio/dac/ti,dac082s085.yaml b/Documentation/devicetree/bindings/iio/dac/ti,dac082s085.yaml > index b0157050f1ee..201b04af2b22 100644 > --- a/Documentation/devicetree/bindings/iio/dac/ti,dac082s085.yaml > +++ b/Documentation/devicetree/bindings/iio/dac/ti,dac082s085.yaml > @@ -33,21 +33,22 @@ properties: > vref-supply: > description: Needed to provide output scaling. > > - spi-max-frequency: true > - > required: > - compatible > - reg > - vref-supply > > -additionalProperties: false > - > oneOf: > - required: > - spi-cpha > - required: > - spi-cpol > > +allOf: > + - $ref: /schemas/spi/spi-peripheral-props.yaml# > + > +unevaluatedProperties: false > + > examples: > - | > vref_2v5_reg: regulator-vref { Just to double-check because I'm unsure how the allOf interacts with the oneOf above: The DT must specify either spi-cpha or spi-cpol for this device, but not both. Hopefully that's still enforced after your change? Thanks, Lukas