Re: [PATCH v4 06/10] iio: magnetometer: yas530: Rename functions and registers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andy,

On 04.07.22 20:04, Andy Shevchenko wrote:
> On Mon, Jul 4, 2022 at 12:03 AM Jakob Hauser <jahau@xxxxxxxxxxxxxx> wrote:
>>
...
>>  /**
>> - * yas5xx_measure() - Make a measure from the hardware
>> + * yas530_measure() - Make a measure from the hardware
>>   * @yas5xx: The device state
>>   * @t: the raw temperature measurement
>>   * @x: the raw x axis measurement
>> @@ -190,7 +192,8 @@ static u16 yas532_extract_axis(u8 *data)
>>   * @y2: the y2 axis measurement
>>   * @return: 0 on success or error code
>>   */
>> -static int yas5xx_measure(struct yas5xx *yas5xx, u16 *t, u16 *x, u16 *y1, u16 *y2)
>> +/* Used by YAS530, YAS532 and YAS533 */
> 
> Why a separate comment and not embedded into the kernel doc above?
> 

I thought of it as an internal comment or hint. I'm not familiar with
kernel doc and didn't dare to add it there.

I'll move it to the bottom of the kernel doc part.

Kind regards,
Jakob



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux