Re: [PATCH v2 3/3] iio: humidity: dht11: Use dev_err_probe consistently

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 18 Jul 2022 22:32:17 +0200
Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote:

> On Mon, Jul 18, 2022 at 10:29 PM Andy Shevchenko
> <andy.shevchenko@xxxxxxxxx> wrote:
> > On Mon, Jul 18, 2022 at 9:51 PM Uwe Kleine-König <ukleinek@xxxxxxxxxx> wrote:  
> 
> ...
> 
> > And to be honest I don't like this desc_to_gpio() usage. It's not for
> > board files, it will bring confusing information to the user. What is
> > important is the name of GPIO, i.o.w. "connection id".  
> 
> Yes, I have noticed that this is in the original code, just if you
> want to make it better at the same time. Not sure if Jonathan wants
> all these in the single patch again, however it will touch almost the
> same line in all (three ?).
> 
So ideal would be separate patches for the different change types, but
meh, that's a pain as you say so given it's just a few lines I'm
fine with whatever combining you want to do.





[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux