On Mon, Jul 11, 2022 at 3:39 PM Shreeya Patel <shreeya.patel@xxxxxxxxxxxxx> wrote: > On 11/07/22 18:36, Andy Shevchenko wrote: > > On Mon, Jul 11, 2022 at 1:30 PM Shreeya Patel Please, remove unneeded context when replying! ... > >> +static const struct regmap_config ltrf216a_regmap_config = { > >> + .name = LTRF216A_DRV_NAME, > >> + .reg_bits = 8, > >> + .val_bits = 8, > >> + .max_register = LTRF216A_MAX_REG, > > Why do you use regmap locking? What for? > > Why do we want to skip the internal locking if it doesn't bring any > benefits? Can you elaborate on the "no benefits" part, please? -- With Best Regards, Andy Shevchenko