On Thu, 30 Jun 2022 09:51:55 +0200
Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx> wrote:
> Add spi_device_id to silent following warning:
> SPI driver tsc2046 has no spi_device_id for ti,tsc2046e-adc
>
> Signed-off-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
If the device was probed via this path (old school board file
or similar) then the device_get_matchdata() call will fail.
So I think we need to add handling for this case. Usually
along lines of
if (dev_fwnode)
.. device_get_match_data()
else
.. handle what is the spi_device_id structure
> ---
> drivers/iio/adc/ti-tsc2046.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/iio/adc/ti-tsc2046.c b/drivers/iio/adc/ti-tsc2046.c
> index 55b35570ad8b..27dc959aee37 100644
> --- a/drivers/iio/adc/ti-tsc2046.c
> +++ b/drivers/iio/adc/ti-tsc2046.c
> @@ -833,11 +833,18 @@ static const struct of_device_id ads7950_of_table[] = {
> };
> MODULE_DEVICE_TABLE(of, ads7950_of_table);
>
> +static const struct spi_device_id tsc2046_adc_spi_ids[] = {
> + { "tsc2046e-adc" },
> + { },
> +};
> +MODULE_DEVICE_TABLE(spi, tsc2046_adc_spi_ids);
> +
> static struct spi_driver tsc2046_adc_driver = {
> .driver = {
> .name = "tsc2046",
> .of_match_table = ads7950_of_table,
> },
> + .id_table = tsc2046_adc_spi_ids,
> .probe = tsc2046_adc_probe,
> };
> module_spi_driver(tsc2046_adc_driver);
