On Sat, 18 Jun 2022, ChiaEn Wu wrote:
> Hi Lee,
>
> Thanks for your helpful comments, we have some questions and replies below.
>
> Lee Jones <lee.jones@xxxxxxxxxx> 於 2022年6月16日 週四 清晨6:49寫道：
>
> >
> > On Mon, 13 Jun 2022, ChiaEn Wu wrote:
> >
> > > From: ChiYuan Huang <cy_huang@xxxxxxxxxxx>
> > >
> > > Add Mediatek MT6370 MFD support.
> > >
> > > Signed-off-by: ChiYuan Huang <cy_huang@xxxxxxxxxxx>
> > > ---
> > > drivers/mfd/Kconfig | 13 ++
> > > drivers/mfd/Makefile | 1 +
> > > drivers/mfd/mt6370.c | 349 +++++++++++++++++++++++++++++++++++++++++++
> > > 3 files changed, 363 insertions(+)
> > > create mode 100644 drivers/mfd/mt6370.c
> > >
> > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> > > index 3b59456f5545..d9a7524a3e0e 100644
> > > --- a/drivers/mfd/Kconfig
> > > +++ b/drivers/mfd/Kconfig
> > > @@ -937,6 +937,19 @@ config MFD_MT6360
> > > PMIC part includes 2-channel BUCKs and 2-channel LDOs
> > > LDO part includes 4-channel LDOs
> > >
> > > +config MFD_MT6370
> > > + tristate "Mediatek MT6370 SubPMIC"
> > > + select MFD_CORE
> > > + select REGMAP_I2C
> > > + select REGMAP_IRQ
> > > + depends on I2C
> > > + help
> > > + Say Y here to enable MT6370 SubPMIC functional support.
> > > + It integrate single cell battery charger with adc monitoring, RGB
> >
> > s/integrates/consists of a/
> >
> > "ADC"
>
> We will fine it in the next patch.
>
> >
> > > + LEDs, dual channel flashlight, WLED backlight driver, display bias
> >
> > > + voltage supply, one general purpose LDO, and cc logic
> > > + controller with USBPD commmunication capable.
> >
> > The last part makes no sense - "and is USBPD"?
>
> If we modify this help text to
> "one general purpose LDO, and the USB Type-C & PD controller complies
> with the latest USB Type-C and PD standards",
> did these modifications meet your expectations?
"one general purpose LDO and a USB Type-C & PD controller that
complies with the latest USB Type-C and PD standards"
Better?
> > > config MFD_MT6397
> > > tristate "MediaTek MT6397 PMIC Support"
> > > select MFD_CORE
> > > diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
> > > index 858cacf659d6..62b27125420e 100644
> > > --- a/drivers/mfd/Makefile
> > > +++ b/drivers/mfd/Makefile
> > > @@ -242,6 +242,7 @@ obj-$(CONFIG_INTEL_SOC_PMIC_BXTWC) += intel_soc_pmic_bxtwc.o
> > > obj-$(CONFIG_INTEL_SOC_PMIC_CHTWC) += intel_soc_pmic_chtwc.o
> > > obj-$(CONFIG_INTEL_SOC_PMIC_CHTDC_TI) += intel_soc_pmic_chtdc_ti.o
> > > obj-$(CONFIG_MFD_MT6360) += mt6360-core.o
> > > +obj-$(CONFIG_MFD_MT6370) += mt6370.o
> > > mt6397-objs := mt6397-core.o mt6397-irq.o mt6358-irq.o
> > > obj-$(CONFIG_MFD_MT6397) += mt6397.o
> > > obj-$(CONFIG_INTEL_SOC_PMIC_MRFLD) += intel_soc_pmic_mrfld.o
> > > diff --git a/drivers/mfd/mt6370.c b/drivers/mfd/mt6370.c
> > > new file mode 100644
> > > index 000000000000..6af9f73c9c0c
> > > --- /dev/null
> > > +++ b/drivers/mfd/mt6370.c
> > > @@ -0,0 +1,349 @@
> > > +// SPDX-License-Identifier: GPL-2.0
> > > +
> > > +#include <linux/bits.h>
> > > +#include <linux/i2c.h>
> > > +#include <linux/interrupt.h>
> > > +#include <linux/kernel.h>
> > > +#include <linux/mfd/core.h>
> > > +#include <linux/module.h>
> > > +#include <linux/regmap.h>
> > > +
> > > +enum {
> > > + MT6370_USBC_I2C = 0,
> > > + MT6370_PMU_I2C,
> > > + MT6370_MAX_I2C
> > > +};
> > > +
> > > +#define MT6370_REG_DEV_INFO 0x100
> > > +#define MT6370_REG_CHG_IRQ1 0x1C0
> > > +#define MT6370_REG_CHG_MASK1 0x1E0
> > > +
> > > +#define MT6370_VENID_MASK GENMASK(7, 4)
> > > +
> > > +#define MT6370_NUM_IRQREGS 16
> > > +#define MT6370_USBC_I2CADDR 0x4E
> > > +#define MT6370_REG_ADDRLEN 2
> > > +#define MT6370_REG_MAXADDR 0x1FF
> > > +
> > > +/* IRQ definitions */
> > > +#define MT6370_IRQ_DIRCHGON 0
> > > +#define MT6370_IRQ_CHG_TREG 4
> > > +#define MT6370_IRQ_CHG_AICR 5
> > > +#define MT6370_IRQ_CHG_MIVR 6
> > > +#define MT6370_IRQ_PWR_RDY 7
> > > +#define MT6370_IRQ_FL_CHG_VINOVP 11
> > > +#define MT6370_IRQ_CHG_VSYSUV 12
> > > +#define MT6370_IRQ_CHG_VSYSOV 13
> > > +#define MT6370_IRQ_CHG_VBATOV 14
> > > +#define MT6370_IRQ_CHG_VINOVPCHG 15
> > > +#define MT6370_IRQ_TS_BAT_COLD 20
> > > +#define MT6370_IRQ_TS_BAT_COOL 21
> > > +#define MT6370_IRQ_TS_BAT_WARM 22
> > > +#define MT6370_IRQ_TS_BAT_HOT 23
> > > +#define MT6370_IRQ_TS_STATC 24
> > > +#define MT6370_IRQ_CHG_FAULT 25
> > > +#define MT6370_IRQ_CHG_STATC 26
> > > +#define MT6370_IRQ_CHG_TMR 27
> > > +#define MT6370_IRQ_CHG_BATABS 28
> > > +#define MT6370_IRQ_CHG_ADPBAD 29
> > > +#define MT6370_IRQ_CHG_RVP 30
> > > +#define MT6370_IRQ_TSHUTDOWN 31
> > > +#define MT6370_IRQ_CHG_IINMEAS 32
> > > +#define MT6370_IRQ_CHG_ICCMEAS 33
> > > +#define MT6370_IRQ_CHGDET_DONE 34
> > > +#define MT6370_IRQ_WDTMR 35
> > > +#define MT6370_IRQ_SSFINISH 36
> > > +#define MT6370_IRQ_CHG_RECHG 37
> > > +#define MT6370_IRQ_CHG_TERM 38
> > > +#define MT6370_IRQ_CHG_IEOC 39
> > > +#define MT6370_IRQ_ADC_DONE 40
> > > +#define MT6370_IRQ_PUMPX_DONE 41
> > > +#define MT6370_IRQ_BST_BATUV 45
> > > +#define MT6370_IRQ_BST_MIDOV 46
> > > +#define MT6370_IRQ_BST_OLP 47
> > > +#define MT6370_IRQ_ATTACH 48
> > > +#define MT6370_IRQ_DETACH 49
> > > +#define MT6370_IRQ_HVDCP_STPDONE 51
> > > +#define MT6370_IRQ_HVDCP_VBUSDET_DONE 52
> > > +#define MT6370_IRQ_HVDCP_DET 53
> > > +#define MT6370_IRQ_CHGDET 54
> > > +#define MT6370_IRQ_DCDT 55
> > > +#define MT6370_IRQ_DIRCHG_VGOK 59
> > > +#define MT6370_IRQ_DIRCHG_WDTMR 60
> > > +#define MT6370_IRQ_DIRCHG_UC 61
> > > +#define MT6370_IRQ_DIRCHG_OC 62
> > > +#define MT6370_IRQ_DIRCHG_OV 63
> > > +#define MT6370_IRQ_OVPCTRL_SWON 67
> > > +#define MT6370_IRQ_OVPCTRL_UVP_D 68
> > > +#define MT6370_IRQ_OVPCTRL_UVP 69
> > > +#define MT6370_IRQ_OVPCTRL_OVP_D 70
> > > +#define MT6370_IRQ_OVPCTRL_OVP 71
> > > +#define MT6370_IRQ_FLED_STRBPIN 72
> > > +#define MT6370_IRQ_FLED_TORPIN 73
> > > +#define MT6370_IRQ_FLED_TX 74
> > > +#define MT6370_IRQ_FLED_LVF 75
> > > +#define MT6370_IRQ_FLED2_SHORT 78
> > > +#define MT6370_IRQ_FLED1_SHORT 79
> > > +#define MT6370_IRQ_FLED2_STRB 80
> > > +#define MT6370_IRQ_FLED1_STRB 81
> > > +#define mT6370_IRQ_FLED2_STRB_TO 82
> > > +#define MT6370_IRQ_FLED1_STRB_TO 83
> > > +#define MT6370_IRQ_FLED2_TOR 84
> > > +#define MT6370_IRQ_FLED1_TOR 85
> > > +#define MT6370_IRQ_OTP 93
> > > +#define MT6370_IRQ_VDDA_OVP 94
> > > +#define MT6370_IRQ_VDDA_UV 95
> > > +#define MT6370_IRQ_LDO_OC 103
> > > +#define MT6370_IRQ_BLED_OCP 118
> > > +#define MT6370_IRQ_BLED_OVP 119
> > > +#define MT6370_IRQ_DSV_VNEG_OCP 123
> > > +#define MT6370_IRQ_DSV_VPOS_OCP 124
> > > +#define MT6370_IRQ_DSV_BST_OCP 125
> > > +#define MT6370_IRQ_DSV_VNEG_SCP 126
> > > +#define MT6370_IRQ_DSV_VPOS_SCP 127
> > > +
> > > +struct mt6370_info {
> > > + struct i2c_client *i2c[MT6370_MAX_I2C];
> > > + struct device *dev;
> > > + struct regmap *regmap;
> > > + struct regmap_irq_chip_data *irq_data;
> > > +};
> >
> > Can we shove all of the above into a header file?
>
> Well... In Patch v1, we put these "#define IRQ" into
> "include/dt-bindings/mfd/mediatek,mt6370.h".
> But the reviewer of DT files hoped us to remove this header file, we
> put these "#define IRQ" in this .c file.
> Shall we leave them here or put them into the header file in
> "driver/power/supply/mt6370-charger.h"?
Where are they used?
--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
