Re: [PATCH v3 2/8] iio: magnetometer: yas530: Change range of data in volatile register

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jonathan,

On 18.06.22 16:21, Jonathan Cameron wrote:
>
> On Sat, 18 Jun 2022 02:13:10 +0200
> Jakob Hauser <jahau@xxxxxxxxxxxxxx> wrote:
...
>>  	return reg == YAS5XX_ACTUATE_INIT_COIL ||
>>  		reg == YAS5XX_MEASURE ||
>> -		(reg >= YAS5XX_MEASURE_DATA && reg <= YAS5XX_MEASURE_DATA + 8);
>> +		(reg >= YAS5XX_MEASURE_DATA && reg <= YAS5XX_MEASURE_DATA + 7);
> trivial, but I'd prefer it as
> reg < RAS5XX_MEASURE_DATA + 8
> because we have 8 registers and do bulk reads of sizeof(u8[8]) so it is more natural
> to use 8 as the constant.

OK, I'll change that. Need to slightly change the commit message then,
I'll probably add a sentence.

Kind regards,
Jakob



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux