Re: [PATCH v2 7/7] iio: magnetometer: yas530: Add YAS537 variant

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 15.06.22 23:43, Jakob Hauser wrote:
> 
> On 13.06.22 17:20, Andy Shevchenko wrote:
>>
>> On Mon, Jun 13, 2022 at 3:18 AM Jakob Hauser <jahau@xxxxxxxxxxxxxx> wrote:
>>>
>>> - * YAS537 MS-3T (2015 Samsung Galaxy S6, Note 5, Xiaomi)
>>> + * YAS537 MS-3T (2015 Samsung Galaxy S6, Note 5, Galaxy S7)
>>
>> Not sure what happened to Xiaomi. There is nothing in the commit
>> message about this change.
> 
> "Xiaomi" is too generic, specific devices should be listed here. E.g.
> Xiaomi Redmi 2 seems to have YAS537 but I'm fully sure this applies to
> all its variants [1]. Samsung Galaxy S7 (and S7 edge) is often quoted in
> conjunction with YAS537, so I took this.

I forgot a "not" here:

"[...] but I'm *not* fully sure this applies to all its variants [...]"



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux