Hi Andy, (Side note: There is something wrong with the Cc list in your e-mail, the list of addresses isn't handled correctly.) On 11.06.22 12:56, Andy Shevchenko wrote: > On Sat, Jun 11, 2022 at 1:57 AM Jakob Hauser <jahau@xxxxxxxxxxxxxx> wrote: >> Ok, I'll remove those direct regmap reads in yas537_dump_calibration(). > > I'm not sure I understand what you are going to drop. I was talking > about debug messages, the regmap reads are fine. Or you are talking > about them as they are tightened together and one makes no sense > without the other? Yes on your question. In the new function yas537_dump_calibration() I added some regmap reads that are performed only because of debug messages. I'll remove those regmap reads incl. the corresponding debug messages. However, I'd like to keep the "other" debug messages. I'll explain more detailed. Generally speaking on YAS530/532: At driver probe, calibration "raw" data is read from the calibration register (currently YAS5XX_CAL). Within the driver, this data gets processed into several calibration coefficients like e.g. c->a2. These are later on applied on the measure data. Calibration debug on YAS530/532: After reading the calibration "raw" data from the register (for further processing), we dump that "raw" data to debug. After having "calculated" the calibration coefficients like c->a2 within the driver, we dump them to debug too. Generally speaking on YAS537 version 0: There are two versions of YAS537. Version 0 reads calibration data from the register (YAS537_CAL) and writes it directly back into some other registers. The driver doesn't touch anything. This is done in new function yas537_get_calibration_data() after "case YAS537_VERSION_0:". Generally speaking on YAS537 version 1: Version 1 of YAS537 is a mixture. Some of the data being read from the calibration register (YAS537_CAL) is directly written back to some other registers. But additionally, some calibration coefficients like c->a2 need to be "calculated". This happens in new function yas537_get_calibration_data() after "case YAS537_VERSION_1:". The calibration coefficients will be applied on the measure data later on. Calibration debug on YAS537: In the new function yas537_dump_calibration(), I implemented that mixture also. Firstly, I added some regmap reads and debug dumps of the registers where some of the calibration data was written into. Secondly, for YAS537 version 1, I dumped the "calculated" calibration coefficients like c->a2. What I intend to change for patchset v2: In the new function yas537_dump_calibration(), I'll remove the two "for loops" (they contain the "unnecessary" regmap reads and debug dumps). But I'd like to keep the debug dump of the "calculated" calibration coefficients after the "for loops". >> However, I'd like to keep the others. The calibration data is dumped >> before [1] and after [2] being processed by the driver. This is helpful >> to check if it was processed correctly. Dumping the data is done only >> once at probing. > > Then it should be probably dev_info() in such cases. To my understanding, in this case it's rather debug. If at some point it turns out that the driver doesn't work correctly, it allows a deeper insight on the intermediate steps the driver is doing internally. >> In yas537_dump_calibration(), I'd also like to keep dumping the >> "hard_offsets". Currently there is no linearization formula known for >> YAS537. Providing the "hard_offsets" may help to find a way. > > I understand that, but per se this is not for production esp. taking > into account that regmap has a tracepoint mechanism. Well, ok, I'll drop the "hard_offsets" debug dump. Kind regards, Jakob
