On Thu, Jun 9, 2022 at 1:38 AM Jakob Hauser <jahau@xxxxxxxxxxxxxx> wrote: > The "hard_offsets" are currently unsigned u8 but they should be signed as they > can get negative. They are signed in function yas5xx_meaure_offsets() and in the > Yamaha drivers [1][2]. > > [1] https://github.com/NovaFusion/android_kernel_samsung_golden/blob/cm-12.1/drivers/sensor/compass/yas.h#L156 > [2] https://github.com/msm8916-mainline/android_kernel_qcom_msm8916/blob/GT-I9195I/drivers/iio/magnetometer/yas_mag_drv-yas532.c#L91 > > Fixes: de8860b1ed47 ("iio: magnetometer: Add driver for Yamaha YAS530") > Cc: Linus Walleij <linus.walleij@xxxxxxxxxx> > Signed-off-by: Jakob Hauser <jahau@xxxxxxxxxxxxxx> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> Yours, Linus Walleij
