Hi Shreeya, Thank you for the patch! Yet something to improve: [auto build test ERROR on jic23-iio/togreg] [also build test ERROR on v5.19-rc1 next-20220608] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Shreeya-Patel/Add-LTRF216A-Driver/20220608-194016 base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20220609/202206091041.MeYKMR6P-lkp@xxxxxxxxx/config) compiler: sh4-linux-gcc (GCC) 11.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/4809a7f42af19c3da77457e1aaf37ddd171fa779 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Shreeya-Patel/Add-LTRF216A-Driver/20220608-194016 git checkout 4809a7f42af19c3da77457e1aaf37ddd171fa779 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=sh SHELL=/bin/bash drivers/iio/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@xxxxxxxxx> All error/warnings (new ones prefixed by >>): >> drivers/iio/light/ltrf216a.c:193:5: warning: no previous prototype for 'ltrf216a_check_for_data' [-Wmissing-prototypes] 193 | int ltrf216a_check_for_data(struct i2c_client *client) | ^~~~~~~~~~~~~~~~~~~~~~~ In file included from include/linux/device.h:25, from include/linux/acpi.h:15, from include/linux/i2c.h:13, from drivers/iio/light/ltrf216a.c:14: >> drivers/iio/light/ltrf216a.c:409:28: error: 'ltrf216a_runtime_suspend' undeclared here (not in a function); did you mean 'pm_runtime_suspend'? 409 | SET_RUNTIME_PM_OPS(ltrf216a_runtime_suspend, | ^~~~~~~~~~~~~~~~~~~~~~~~ include/linux/pm.h:329:28: note: in definition of macro 'RUNTIME_PM_OPS' 329 | .runtime_suspend = suspend_fn, \ | ^~~~~~~~~~ drivers/iio/light/ltrf216a.c:409:9: note: in expansion of macro 'SET_RUNTIME_PM_OPS' 409 | SET_RUNTIME_PM_OPS(ltrf216a_runtime_suspend, | ^~~~~~~~~~~~~~~~~~ >> drivers/iio/light/ltrf216a.c:410:28: error: 'ltrf216a_runtime_resume' undeclared here (not in a function); did you mean 'ltrf216a_int_time_reg'? 410 | ltrf216a_runtime_resume, NULL) | ^~~~~~~~~~~~~~~~~~~~~~~ include/linux/pm.h:330:27: note: in definition of macro 'RUNTIME_PM_OPS' 330 | .runtime_resume = resume_fn, \ | ^~~~~~~~~ drivers/iio/light/ltrf216a.c:409:9: note: in expansion of macro 'SET_RUNTIME_PM_OPS' 409 | SET_RUNTIME_PM_OPS(ltrf216a_runtime_suspend, | ^~~~~~~~~~~~~~~~~~ vim +409 drivers/iio/light/ltrf216a.c 405 406 static const struct dev_pm_ops ltrf216a_pm_ops = { 407 SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, 408 pm_runtime_force_resume) > 409 SET_RUNTIME_PM_OPS(ltrf216a_runtime_suspend, > 410 ltrf216a_runtime_resume, NULL) 411 }; 412 -- 0-DAY CI Kernel Test Service https://01.org/lkp