On Fri, Jun 03, 2022 at 02:57:09PM +0100, Aidan MacDonald wrote: > The AXP192 PMIC is different enough from the PMICs supported by > the AXP20x GPIO driver to warrant a separate driver. The AXP192 > driver also supports interrupts and pinconf settings. > > Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@xxxxxxxxx> > --- > .../bindings/gpio/x-powers,axp192-gpio.yaml | 59 +++++++++++++++++++ > 1 file changed, 59 insertions(+) > create mode 100644 Documentation/devicetree/bindings/gpio/x-powers,axp192-gpio.yaml > > diff --git a/Documentation/devicetree/bindings/gpio/x-powers,axp192-gpio.yaml b/Documentation/devicetree/bindings/gpio/x-powers,axp192-gpio.yaml > new file mode 100644 > index 000000000000..7a985640ade8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/gpio/x-powers,axp192-gpio.yaml > @@ -0,0 +1,59 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/gpio/x-powers,axp192-gpio.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: X-Powers AXP192 GPIO Device Tree Bindings > + > +maintainers: > + - Chen-Yu Tsai <wens@xxxxxxxx> > + > +properties: > + "#gpio-cells": > + const: 2 > + description: > > + The first cell is the pin number and the second is the GPIO flags. > + > + compatible: > + oneOf: > + - enum: No need for 'oneOf' with only 1 entry. > + - x-powers,axp192-gpio > + > + gpio-controller: true > + > +patternProperties: > + "^.*-pins?$": You can omit '^.*' Why does 's' need to be optional? > + $ref: /schemas/pinctrl/pinmux-node.yaml# > + > + properties: > + pins: > + items: > + enum: > + - GPIO0 > + - GPIO1 > + - GPIO2 > + - GPIO3 > + - GPIO4 > + - N_RSTO > + > + function: > + enum: > + - output > + - input > + - ldo > + - pwm > + - adc > + - low_output > + - floating > + - ext_chg_ctl > + - ldo_status > + > +required: > + - compatible > + - "#gpio-cells" > + - gpio-controller > + > +additionalProperties: false > + > +... > -- > 2.35.1 > >