On Tue, May 31, 2022 at 11:47:50PM +0200, Martin Blumenstingl wrote: > On Tue, May 31, 2022 at 11:18 PM Andy Shevchenko > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > [...] > > @@ -650,11 +648,12 @@ static int meson_sar_adc_clk_init(struct iio_dev *indio_dev, > > void __iomem *base) > > { > > struct meson_sar_adc_priv *priv = iio_priv(indio_dev); > > + struct device *idev = &indio_dev->dev; > > + struct device *dev = dev->parent; > It looks like this should read: > struct device *dev = idev->parent; Oops, indeed. > That said, I think this kind of typo is very easy with the current > naming schema. > It's been a while since I looked at other drivers but maybe the IIO > maintainers have some recommendations for us (which would apply to > multiple IIO drivers, not just meson_saradc). > For example: I am not sure if iio_{err,warn} functions (which take a > struct iio_dev pointer) have been proposed/discussed before. I think > they could be useful for other drivers as well. Looking deeper into this example, I think the IIO dev usage might be wrong in the first place, but since there are managed resources attached, I dunno if it's the way to go. Let's wait for maintainers to chime in. -- With Best Regards, Andy Shevchenko