Re: [PATCH v1] iio: trigger: warn about non-registered iio trigger getting attempt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2022-05-31 at 18:57 +0000, Dmitry Rokosov wrote:
> Hi Jonathan,
> 
> I have one question about a cases when trigger owner is builtin
> module.
> In the such cases trig->owner == null, because THIS_MODULE equals to
> null. How do you think, should we take into account such situations?
> 
> IMHO we have to take in and save this information to trig_info during
> trigger allocation call. For example we can check THIS_MODULE from
> the

Hmmm, If we were to do something during iio_trigger_alloc(), we would
rather assign already THIS_MODULE to owner and we would not need this
WARN(). I mean, if someone calls iio_trigger_get() before allocating
it, it will have bigger problems :).

I think this could actually be something reasonable...

- Nuno Sá
> 





[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux