On 31/05/2022 12:42, ChiaEn Wu wrote: > From: Alice Chen <alice_chen@xxxxxxxxxxx> > Subject - same comment as previous #10 patch. > Add Mediatek MT6370 flashlight binding documentation > > Signed-off-by: Alice Chen <alice_chen@xxxxxxxxxxx> > --- > .../leds/mediatek,mt6370-flashlight.yaml | 48 +++++++++++++++++++ > 1 file changed, 48 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/mediatek,mt6370-flashlight.yaml > > diff --git a/Documentation/devicetree/bindings/leds/mediatek,mt6370-flashlight.yaml b/Documentation/devicetree/bindings/leds/mediatek,mt6370-flashlight.yaml > new file mode 100644 > index 000000000000..b1b11bd3d410 > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/mediatek,mt6370-flashlight.yaml > @@ -0,0 +1,48 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/leds/leds-mt6370-flashlight.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Flash LED driver for MT6370 PMIC from MediaTek Integrated. > + > +maintainers: > + - Alice Chen <alice_chen@xxxxxxxxxxx> > + > +description: | > + This module is part of the MT6370 MFD device. > + see Documentation/devicetree/bindings/mfd/mt6370.yaml > + Add MT6370 flash LED driver include 2-channel flash LED support Torch/Strobe Mode. > + > +properties: > + compatible: > + const: mediatek,mt6370-flashlight > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > +patternProperties: > + "^led@[0-1]$": > + type: object > + $ref: common.yaml# > + description: > + Properties for a single flash LED. Same as patch #11. > + > + properties: > + reg: > + description: Index of the flash LED. As well. > + enum: > + - 0 #Address of LED1 > + - 1 #Address of LED2 '#' starts a comment, so there is always a space after '#' > + > + unevaluatedProperties: false > + > +required: > + - compatible > + - "#address-cells" > + - "#size-cells" > + > +additionalProperties: false Best regards, Krzysztof