On Mon, May 23, 2022 at 6:42 PM Dmitry Rokosov <DDRokosov@xxxxxxxxxxxxxx> wrote: > > The following patchset resolves problems with iio_trigger_get() and > iio_trigger_register() call order in the different IIO drivers. > > IIO trigger interface function iio_trigger_get() should be called after > iio_trigger_register() (or its devm analogue) strictly, because of > iio_trigger_get() acquires module refcnt based on the trigger->owner > pointer, which is initialized inside iio_trigger_register() to > THIS_MODULE. > If this call order is wrong, the next iio_trigger_put() (from sysfs > callbacks or rmmod) will derefence "default" module refcnt, which is dereference > completely incorrect. Cool set! But it sounds like a set of fixes, can you add a Fixes tag to each of the patches? -- With Best Regards, Andy Shevchenko
