On 11/05/2022 21:08, Eddie James wrote: > Document the si7020 bindings with a new "silabs,skip-reset" property. > > Signed-off-by: Eddie James <eajames@xxxxxxxxxxxxx> Thank you for your patch. There is something to discuss/improve. > --- > .../bindings/iio/humidity/silabs,si7020.yaml | 42 +++++++++++++++++++ > 1 file changed, 42 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/humidity/silabs,si7020.yaml > > diff --git a/Documentation/devicetree/bindings/iio/humidity/silabs,si7020.yaml b/Documentation/devicetree/bindings/iio/humidity/silabs,si7020.yaml > new file mode 100644 > index 000000000000..ab53bb8d9606 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/humidity/silabs,si7020.yaml > @@ -0,0 +1,42 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/humidity/silabs,si7020.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: SI7020 humidity + temperature sensor > + > +maintainers: > + - David Barksdale <dbarksdale@xxxxxxxxxxx> > + > +description: | > + The Silicon Labs Si7013/20/21 Relative Humidity and Temperature Sensors > + are i2c devices which have an identical programming interface for > + measuring relative humidity and temperature. > + > +properties: > + compatible: > + const: silabs,si7020 > + > + reg: > + maxItems: 1 > + > + siliabs,skip-reset: Do not describe implementation (driver) behavior, but the device hardware. > + $ref: /schemas/types.yaml#/definitions/flag "type:boolean" is shorter > + description: > + Disables resetting of the device during probe > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + si7021-a20@40 { Generic node name, so "sensor"? > + silabs,skip-reset; > + compatible = "silabs,si7020"; > + reg = <0x40>; Order the properties: 1. compatible, 2. reg, then the rest. > + }; > +... Best regards, Krzysztof
