Hi Geert, Thanks for the feedback. > Subject: Re: [PATCH] iio: adc: rzg2l_adc: Add support for RZ/G2UL ADC > > Hi Biju, > > On Tue, May 3, 2022 at 9:47 AM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > wrote: > > > Subject: Re: [PATCH] iio: adc: rzg2l_adc: Add support for RZ/G2UL > > >ADC On Tue, May 3, 2022 at 8:54 AM Biju Das > > > These can be dropped, as dtbs_check should take care of that. > > > > OK, Will remove this. > > Actually it's OK to keep them, as they are the upper limits supported by > the hardware block. You mean use upper limit of 2 for RZ/G2UL and 8 for RZ/G2L, right? For eg:- If we use, Channel0 and channel 2 :- this will be caught in dtbs as /home/biju/rzg2l-linux/Documentation/devicetree/bindings/iio/adc/renesas,rzg2l-adc.example.dtb: adc@10059000: channel@2:reg:0:0: 2 is greater than the maximum of 1 But for run time, we don't want to this to happen for RZ/G2UL?? So if replace (channel >= RZG2L_ADC_MAX_CHANNELS) -> (channel >= adc->max_channel) will take of this. Cheers, Biju
